Subject: | I would replace preg_split for... |
Summary: | Package rating comment |
Messages: | 2 |
Author: | RicardoSaracino |
Date: | 2011-04-18 12:45:31 |
Update: | 2011-04-19 13:22:04 |
|
|
|
RicardoSaracino rated this package as follows:
Utility: | Sufficient |
Consistency: | Sufficient |
Examples: | Good |
|
 RicardoSaracino - 2011-04-18 12:45:31
I would replace preg_split for str_split to get some better efficiency from the __get
mysql_real_escape_string is a bad idea as it depends on a mysql installation. perhaps use addslashes to keep it from breaking on other systems or have way to register a callback for escaping using addslashes as the default
 Zulfugar Ismayilzadeh - 2011-04-19 13:22:04 - In reply to message 1 from RicardoSaracino
I'll use explode in the bext versions of this class.
We used mysql_real_escape_string, because we have mysql platform. In next version i'll check, if mysql platform exists we'll use mysql_real_escape_string, else addslashes.
|